Thread (1 message) 1 message, 1 author, 2017-03-21

Re: [PATCH v4 1/3] checks: Add bus checks for PCI buses

From: David Gibson <hidden>
Date: 2017-03-21 03:46:48

On Mon, Mar 20, 2017 at 09:44:16AM -0500, Rob Herring wrote:
Add PCI bridge and device node checks. We identify PCI bridges with
'device_type = "pci"' as only PCI bridges should set that property. For
bridges, check that node name is pci or pcie, ranges and bus-range are
present, and #address-cells and #size-cells are correct.

For devices, check the reg property fields are correct for the first
element (the config address). Check that the unit address is formatted
corectly based on the reg property. Device unit addresses are in the
form DD or DD,F where DD is the device 0-0x1f and F is the function 0-7.
Also, check that the bus number is within the expected range defined by
bridge's bus-ranges.

Reviewed-by: David Gibson <redacted>
Signed-off-by: Rob Herring <redacted>
Applied, with a small change..

[snip]
+WARNING(pci_device_reg, check_pci_device_reg, NULL, &reg_format);
..adding pci_bridge to the dependency list here.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help