Thread (18 messages) 18 messages, 6 authors, 2017-03-20

Re: [PATCH v2 05/11] Documentation: DT: bindings: mfd: add A33 GPADC binding

From: Icenowy Zheng <hidden>
Date: 2017-03-10 19:33:51
Also in: linux-arm-kernel, linux-iio


10.03.2017, 20:26, "Maxime Ripard" [off-list ref]:
On Fri, Mar 10, 2017 at 11:39:15AM +0100, Quentin Schulz wrote:
quoted
 This patch adds documentation for the A33 GPADC binding.

 Signed-off-by: Quentin Schulz [off-list ref]
 ---

 added in v2

  .../devicetree/bindings/mfd/sun4i-gpadc.txt | 59 ++++++++++++++++++++++
  1 file changed, 59 insertions(+)
  create mode 100644 Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt

 diff --git a/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
 new file mode 100644
 index 0000000..17242c8
 --- /dev/null
 +++ b/Documentation/devicetree/bindings/mfd/sun4i-gpadc.txt
 @@ -0,0 +1,59 @@
 +Allwinner SoCs' GPADC Device Tree bindings
 +------------------------------------------
 +The Allwinner SoCs all have an ADC that can also act as a thermal sensor
 +and sometimes as a touchscreen controller.
 +
 +Required properties:
 + - compatible: "sun8i-a33-gpadc-iio",
This doesn't match your example, and you shouldn't have IIO in
there. Compatibles shouldn't be tied to a given framework, since that
is Linux specific (and might even change in the future).
From this aspect, I think we shouldn't even call it gpadc in compatible --
as it's not GP at all on A33.
Maxime

--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
,

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help