Re: [PATCH v4 4/4] mvebu: wrt1900ac: Use pwm-fan rather than gpio-fan
From: Gregory CLEMENT <hidden>
Date: 2017-03-30 16:01:58
Also in:
linux-arm-kernel, linux-gpio, linux-pwm, lkml
Hi Ralph, On lun., mars 27 2017, Ralph Sennhauser [off-list ref] wrote: Here again the title should start with ARM: dts: armada-xp. As for the other patch if there is no need for a v5 I will fix it while appliig it. Thanks, Gregory
quoted hunk
From: Andrew Lunn <redacted> The mvebu GPIO driver can also perform PWM on some pins. Use the pwm-fan driver to control the fan of the WRT1900AC, giving us finer grained control over its speed and hence noise. Signed-off-by: Andrew Lunn <redacted> URL: https://patchwork.ozlabs.org/patch/427291/ [Ralph Sennhauser: drop flags paramter from pwms, no longer used] Signed-off-by: Ralph Sennhauser <redacted> --- arch/arm/boot/dts/armada-xp-linksys-mamba.dts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-)diff --git a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts index 9efcf59..6d705f5 100644 --- a/arch/arm/boot/dts/armada-xp-linksys-mamba.dts +++ b/arch/arm/boot/dts/armada-xp-linksys-mamba.dts@@ -308,13 +308,11 @@ }; }; - gpio_fan { + pwm_fan { /* SUNON HA4010V4-0000-C99 */ - compatible = "gpio-fan"; - gpios = <&gpio0 24 0>; - gpio-fan,speed-map = <0 0 - 4500 1>; + compatible = "pwm-fan"; + pwms = <&gpio0 24 4000>; }; dsa {-- 2.10.2
-- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html