Re: [PATCH v6 1/5] irqchip/aspeed-i2c-ic: binding docs for Aspeed I2C Interrupt Controller
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: 2017-03-28 08:50:38
Also in:
linux-i2c, lkml, openbmc
On Mon, 2017-03-27 at 22:12 -0700, Brendan Higgins wrote:
Added device tree binding documentation for Aspeed I2C Interrupt Controller.
It's a little bit overkill ... It's not so much an interrupt controller than a single "summary" register that reflects the state of the interrupts of all the i2c controllers ;-) It can't do anything with them, no individual masking or acking or similar. In fact to be honest I wouldn't even have bothered making it an irq_domain in the first place though it *is* nice I admit to see the interrupt counts per bus in /proc/interrupts as a result. Cheers, Ben.
quoted hunk ↗ jump to hunk
Signed-off-by: Brendan Higgins <redacted> --- Added in v6: - Pulled "aspeed_i2c_controller" out into a interrupt controller since that is what it actually does. --- .../interrupt-controller/aspeed,ast2400-i2c-ic.txt | 25 ++++++++++++++++++++++ 1 file changed, 25 insertions(+) create mode 100644 Documentation/devicetree/bindings/interrupt- controller/aspeed,ast2400-i2c-ic.txtdiff --git a/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-i2c-ic.txt b/Documentation/devicetree/bindings/interrupt- controller/aspeed,ast2400-i2c-ic.txt new file mode 100644 index 000000000000..033cc82e5684--- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/aspeed,ast2400-i2c-ic.txt@@ -0,0 +1,25 @@ +Device tree configuration for the I2C Interrupt Controller on theAST24XX and +AST25XX SoCs. + +Required Properties: +- #address-cells : should be 1 +- #size-cells : should be 1 +- #interrupt-cells : should be 1 +- compatible : should be "aspeed,ast2400-i2c-ic" + or "aspeed,ast2500-i2c-ic" +- reg : address start and range of controller +- interrupts : interrupt number +- interrupt-controller : denotes that the controller receives and fires + new interrupts for child busses + +Example: + +i2c_ic: interrupt-controller@0 { + #address-cells = <1>; + #size-cells = <1>; + #interrupt-cells = <1>; + compatible = "aspeed,ast2400-i2c-ic"; + reg = <0x0 0x40>; + interrupts = <12>; + interrupt-controller; +};