Thread (17 messages) 17 messages, 3 authors, 2017-03-27

[PATCH v11 11/12] iio: multiplexer: fix unsigned check with less than zero

STALE3477d REVIEWED: 7 (7M)

From: Peter Rosin <hidden>
Date: 2017-03-27 12:19:27
Also in: linux-i2c, linux-iio, lkml
Subsystem: iio multiplexer, iio subsystem and drivers, the rest · Maintainers: Peter Rosin, Jonathan Cameron, Linus Torvalds

Revision v11 of 5 in this series; 1 review trailer (1 from subsystem maintainers).

Revisions (5)
  1. v7 [diff vs current]
  2. v8 [diff vs current]
  3. v10 [diff vs current]
  4. v11 current
  5. v14 [diff vs current]
Comparing a size_t with less than zero is always false as size_t
is unsigned. So, change the type of the variable to ssize_t and
replicate the size check from mux_configure_channel() into
mux_write_ext_info() thus ensuring that the size will fit in the
ssize_t variable.

Detected by CoverityScan, CID#1415278 ("Unsigned compared against 0")

Fixes: 1da8e16d2812 ("iio: multiplexer: new iio category and iio-mux driver")
Reported-by: Colin Ian King <redacted>
Acked-by: Jonathan Cameron <jic23@kernel.org>
Signed-off-by: Peter Rosin <redacted>
---
 drivers/iio/multiplexer/iio-mux.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/multiplexer/iio-mux.c b/drivers/iio/multiplexer/iio-mux.c
index 94d40f9bef4c..bab9e6902090 100644
--- a/drivers/iio/multiplexer/iio-mux.c
+++ b/drivers/iio/multiplexer/iio-mux.c
@@ -21,7 +21,7 @@
 
 struct mux_ext_info_cache {
 	char *data;
-	size_t size;
+	ssize_t size;
 };
 
 struct mux_child {
@@ -206,6 +206,9 @@ static ssize_t mux_write_ext_info(struct iio_dev *indio_dev, uintptr_t private,
 	char *new;
 	ssize_t ret;
 
+	if (len >= PAGE_SIZE)
+		return -EINVAL;
+
 	ret = iio_mux_select(mux, idx);
 	if (ret < 0)
 		return ret;
-- 
2.1.4
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help