Thread (27 messages) 27 messages, 5 authors, 2017-03-23

Re: [PATCHv2 09/11] Bluetooth: add nokia driver

From: Sebastian Reichel <hidden>
Date: 2017-03-22 22:48:45
Also in: linux-bluetooth, linux-serial, lkml

Hi,

On Wed, Mar 22, 2017 at 04:26:28PM -0500, Rob Herring wrote:
On Tue, Mar 21, 2017 at 5:32 PM, Sebastian Reichel [off-list ref] wrote:
quoted
This adds a driver for the Nokia H4+ protocol, which is used
at least on the Nokia N9, N900 & N950.

Signed-off-by: Sebastian Reichel <redacted>
---
quoted
+       btdev->wakeup_host = devm_gpiod_get(dev, "host-wakeup", GPIOD_IN);
+       if (IS_ERR(btdev->wakeup_host)) {
+               err = PTR_ERR(btdev->wakeup_host);
+               dev_err(dev, "could not get host wakeup gpio: %d", err);
+               return err;
+       }
+
+       btdev->wake_irq = gpiod_to_irq(btdev->wakeup_host);
Missed this in the binding review, but generally, we make these
interrupts rather than gpios in the binding.
I also read the state of the GPIO. AFAIK it's not possible to read
the state of an IRQ, so I can't switch to IRQ.
quoted
+
+       err = devm_request_threaded_irq(dev, btdev->wake_irq, NULL,
+               wakeup_handler,
+               IRQF_TRIGGER_RISING | IRQF_TRIGGER_FALLING | IRQF_ONESHOT,
+               "wakeup", btdev);
+       if (err) {
+               dev_err(dev, "could request wakeup irq: %d", err);
+               return err;
+       }
-- Sebastian

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help