Re: [PATCH 1/4] gpio: mvebu: Add limited PWM support

quoted

+static void mvebu_pwm_free(struct pwm_chip *chip, struct pwm_device *pwmd)
+{
+       struct mvebu_pwm *pwm = to_mvebu_pwm(chip);
+       struct gpio_desc *desc = gpio_to_desc(pwmd->pwm);
+       unsigned long flags;
+
+       spin_lock_irqsave(&pwm->lock, flags);
+       gpiod_free(desc);
+       pwm->used = false;
+       spin_unlock_irqrestore(&pwm->lock, flags);
+}

No need to set the output value to zero or something here?
And turn off blinking? Or is that done some other way?

Hi Linus

The disable op will turn of blinking. I've not checked, but i assume
the PWM core will not allow you to free an enabled PWM?

I think both of these need to be tagged __maybe_unused to not give
noise in randconfig builds.

I've not seen any 0-day patch emails giving warnings. So i suspect it
is O.K.

   Andrew