Thread (10 messages) 10 messages, 5 authors, 2017-03-16

Re: [PATCH v2 2/3] Input: add support for the STMicroelectronics FingerTip touchscreen

From: Andrzej Hajda <hidden>
Date: 2017-03-16 08:33:28
Also in: linux-input, linux-samsung-soc, lkml

Hi Andi,

On 10.02.2017 03:17, Andi Shyti wrote:
(...)
+
+	err = devm_request_threaded_irq(&client->dev, client->irq,
+					NULL, stmfts_irq_handler,
+					IRQF_ONESHOT | IRQF_TRIGGER_LOW,
+					"stmfts_irq", sdata);
+	if (err)
+		return err;
+
+	/*
+	 * Disable irq they, they are not needed at this stage.
+	 * One possible case when an IRQ can be already rased is e.g. if the
+	 * regulator is set as always on and the stmfts device sends an IRQ as
+	 * soon as it gets powered, de-synchronizing the power on sequence.
+	 * During power on, the device will be reset and all the initialization
+	 * IRQ will be resent.
+	 */
+	disable_irq(sdata->client->irq);
It is safer to set:
    irq_set_status_flags(client->irq, IRQ_NOAUTOEN);
before devm_request_threaded_irq

Regards
Andrzej
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help