Re: [PATCH v2 2/2] can: spi: hi311x: Add Holt HI-311x CAN driver
From: Wolfgang Grandegger <hidden>
Date: 2017-03-14 12:11:21
Also in:
linux-can, lkml, netdev
From: Wolfgang Grandegger <hidden>
Date: 2017-03-14 12:11:21
Also in:
linux-can, lkml, netdev
Hallo Akshay, Am 13.03.2017 um 16:38 schrieb Akshay Bhat:
Hi Wolfgang, On 03/09/2017 12:36 PM, Wolfgang Grandegger wrote:quoted
Hello, doing a quick review... I realized a few issues... Am 17.01.2017 um 20:22 schrieb Akshay Bhat:
... snip ...
quoted
A few other things to check: Run "cangen" and monitor the message with "candump -e any,0:0,#FFFFFFF". Then 1) disconnect the cable or 2) short-circuit CAN low and high at the connector. You should see error messages. After reconnection or removing the short-circuit (and bus-off recovery) the state should go back to "active".With the above sequence, candump reports "ERRORFRAME" with protocol-violation{{}{acknowledge-slot}}, bus-error. On re-connecting the cable the can state goes back to ACTIVE and I see the messages that were in the queue being sent.
Do you get the ACK error also with berr-reporting off? Would be nice if you could show a candump log here. Also, any error message should show the bus error counts in data[7,8]: http://lxr.free-electrons.com/source/drivers/net/can/sja1000/sja1000.c#L408 And please check bus-off as well (short-circuiting CAN low and high). Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html