Re: [PATCH 10/10] Bluetooth: add nokia driver
From: Marcel Holtmann <hidden>
Date: 2017-03-07 21:58:24
Also in:
linux-bluetooth, linux-serial, lkml
Hi Sebastian,
quoted
quoted
This adds a driver for the Nokia H4+ protocol, which is used at least on the Nokia N9, N900 & N950. Signed-off-by: Sebastian Reichel <redacted> --- .../devicetree/bindings/net/nokia-bluetooth.txt | 51 ++This should be separate and before the dts files.quoted
drivers/bluetooth/Kconfig | 12 + drivers/bluetooth/Makefile | 2 + drivers/bluetooth/hci_nokia.c | 839 +++++++++++++++++++++ 4 files changed, 904 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/nokia-bluetooth.txt create mode 100644 drivers/bluetooth/hci_nokia.cdiff --git a/Documentation/devicetree/bindings/net/nokia-bluetooth.txt b/Documentation/devicetree/bindings/net/nokia-bluetooth.txt new file mode 100644 index 000000000000..6c80a92f31e2 --- /dev/null +++ b/Documentation/devicetree/bindings/net/nokia-bluetooth.txt@@ -0,0 +1,51 @@ +Nokia Bluetooth Chips +--------------------- + +Nokia phones often come with UART connected bluetooth chips from different +vendors and modified device API. Those devices speak a protocol named H4+ +by Nokia, which is similar to the H4 protocol from the Bluetooth standard. +In addition to the H4 protocol it specifies two more UART status lines for +wakeup of UART transceivers to improve power management and a few new packet +types used to negotiate uart speed. + +Required properties: + + - compatible: should be one of the following: + * "nokia,brcm,bcm2048" + * "nokia,ti,wl1271-bluetooth"Drop the chip vendors' prefix here. I don't really want to start a pattern of 2 vendor prefixes.Right, I think we discussed this before, but I don't remember the result. How about - compatible: should contain "nokia,h4p-bluetooth" as well as one of the following: * "brcm,bcm2048-nokia" * "ti,wl1271-blueooth-nokia”
I never liked the term “h4p”. It is fundamentally just “bluetooth”. What are our plans for Broadcom, Intel etc. Bluetooth UARTs? Regards Marcel -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html