Re: [PATCH v10 2/2] media: i2c: Add support for OV5647 sensor.
From: Sakari Ailus <hidden>
Date: 2017-03-07 16:13:48
Also in:
linux-media, lkml
From: Sakari Ailus <hidden>
Date: 2017-03-07 16:13:48
Also in:
linux-media, lkml
Hi Ramiro, On Mon, Mar 06, 2017 at 11:16:34AM +0000, Ramiro Oliveira wrote: ...
+static int __sensor_init(struct v4l2_subdev *sd)
+{
+ int ret;
+ u8 resetval, rdval;
+ struct i2c_client *client = v4l2_get_subdevdata(sd);
+
+ dev_dbg(&client->dev, "sensor init\n");This looks like a debugging time leftover. Please remove. With that, Acked-by: Sakari Ailus <sakari.ailus-VuQAYsv1563Yd54FQh9/CA@public.gmane.org> ...
+static int ov5647_parse_dt(struct device_node *np)
+{
+ struct v4l2_of_endpoint bus_cfg;
+ struct device_node *ep;
+
+ int ret;
+
+ ep = of_graph_get_next_endpoint(np, NULL);
+ if (!ep)
+ return -EINVAL;
+
+ ret = v4l2_of_parse_endpoint(ep, &bus_cfg);
+
+ of_node_put(ep);
+ return ret;
+}This will conflict with my fwnode patchset. Let's see in which order the patches will be merged, one of the sets has to be changed. The work is trivial though. -- Kind regards, Sakari Ailus e-mail: sakari.ailus-X3B1VOXEql0@public.gmane.org XMPP: sailus-PCDdDYkjdNMDXYZnReoRVg@public.gmane.org -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html