Thread (2 messages) 2 messages, 2 authors, 2017-02-22

Re: bug in DT docs vs mcp251x.c driver

From: Janusz Użycki <hidden>
Date: 2017-02-22 07:58:43
Also in: linux-can

Hi Fabio.

You are right. Thanks.
According to the source code printf adds the "-supply" indeed.
I've not verified the code as I got a report for 3.14 that the driver
does not work with vdd-supply in DT, works with vdd property
and the supply was verified electrically.
Now I have to investigate the problem better.

best regards

Janusz


W dniu 2017-02-21 o 19:47, Fabio Estevam pisze:
Hi Janusz,

On Tue, Feb 21, 2017 at 3:08 PM, Janusz Użycki
[off-list ref] wrote:
quoted
Hi,

We've noticed the inconsistency in DT which still exist in kernel v4.10:

devm_regulator_get(&spi->dev, "vdd") in drivers/net/can/mcp251x.c

vs vdd-supply: Regulator that powers the CAN controller. in
bindings/net/can/microchip,mcp251x.txt
This is correct.

When the regulator is retrieved as devm_regulator_get(dev, "xyz") then
it searches for a xyz-supply in the dts.
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help