Thread (3 messages) 3 messages, 3 authors, 2017-02-17

Re: [PATCH v3 0/3] Adding DT support for TI HECC module

From: Marc Kleine-Budde <mkl@pengutronix.de>
Date: 2017-02-17 09:36:27
Also in: linux-can, linux-omap

On 02/17/2017 10:23 AM, Yegor Yefremov wrote:
On Fri, Feb 17, 2017 at 9:51 AM, Marc Kleine-Budde [off-list ref] wrote:
quoted
On 02/17/2017 09:50 AM, Yegor Yefremov wrote:
quoted
On Fri, Feb 17, 2017 at 9:46 AM, Marc Kleine-Budde [off-list ref] wrote:
quoted
On 02/15/2017 03:48 PM, yegorslists@googlemail.com wrote:
quoted
From: Yegor Yefremov <redacted>

This is an attempt to revive DT support for TI HECC that was started in 2015 [1].

Changes v2 -> v3:
  - rename compatible property to "ti,am3517-hecc" (though there is a stipped
    device named 3505, EMAC driver already uses am3517-emac name, so keep this
    property consistent)
  - use reg-names to specify different HECC I/O mapping (suggested by Tony Lindgren)
  - provide fallback offsets and sizes for board files
Are there any board files using te_hecc intree? I don't see any on the
first glance. What about making the driver DT only?
Good idea. I aslo wanted to ask this. So this means we could
completely get rid of include/linux/can/platform/ti_hecc.h?
If there isn't any in-tree user, thes yes.
Btw. what should we do about "@transceiver_switch: platform specific
callback fn for transceiver control"? Model it via something like
this:

enable-gpios = <&gpio6 15 GPIO_ACTIVE_HIGH>; /* gpio 175 */
Make it a regulator as in the flexcan:
	reg_xceiver = devm_regulator_get(&pdev->dev, "xceiver");
Marc

-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help