Re: [PATCH 4/8] v4l2-async: Provide interoperability between OF and fwnode matching

Hi Sakari,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on next-20170213]
[cannot apply to v4.10-rc8]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-flash-led-class-Use-fwnode_handle-instead-of-device_node-in-init/20170213-213642
base:   git://linuxtv.org/media_tree.git master
config: x86_64-randconfig-x008-201707 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All error/warnings (new ones prefixed by >>):

   drivers/media/v4l2-core/v4l2-async.c: In function 'match_of':
   drivers/media/v4l2-core/v4l2-async.c:63:6: error: implicit declaration of function 'of_fwnode_handle' [-Werror=implicit-function-declaration]
         of_fwnode_handle(sd->of_node) : sd->fwnode,
         ^~~~~~~~~~~~~~~~

quoted

drivers/media/v4l2-core/v4l2-async.c:63:36: warning: pointer/integer type mismatch in conditional expression

         of_fwnode_handle(sd->of_node) : sd->fwnode,
                                       ^

quoted

drivers/media/v4l2-core/v4l2-async.c:64:6: warning: passing argument 2 of 'fwnode_cmp' makes pointer from integer without a cast [-Wint-conversion]

         of_fwnode_handle(asd->match.of.node));
         ^~~~~~~~~~~~~~~~
   drivers/media/v4l2-core/v4l2-async.c:44:13: note: expected 'struct fwnode_handle *' but argument is of type 'int'
    static bool fwnode_cmp(struct fwnode_handle *one,
                ^~~~~~~~~~
   drivers/media/v4l2-core/v4l2-async.c: In function 'match_fwnode':
   drivers/media/v4l2-core/v4l2-async.c:70:36: warning: pointer/integer type mismatch in conditional expression
         of_fwnode_handle(sd->of_node) : sd->fwnode,
                                       ^
   cc1: some warnings being treated as errors

vim +/of_fwnode_handle +63 drivers/media/v4l2-core/v4l2-async.c

    57			return one == theother;
    58	}
    59	
    60	static bool match_of(struct v4l2_subdev *sd, struct v4l2_async_subdev *asd)
    61	{
    62		return fwnode_cmp(sd->of_node ?
  > 63				  of_fwnode_handle(sd->of_node) : sd->fwnode,
  > 64				  of_fwnode_handle(asd->match.of.node));
    65	}
    66	
    67	static bool match_fwnode(struct v4l2_subdev *sd, struct v4l2_async_subdev *asd)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation