Re: [PATCH 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init
From: kbuild test robot <hidden>
Date: 2017-02-13 13:56:49
Also in:
linux-acpi, linux-media
Hi Sakari, [auto build test ERROR on linuxtv-media/master] [also build test ERROR on v4.10-rc8 next-20170213] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-flash-led-class-Use-fwnode_handle-instead-of-device_node-in-init/20170213-213642 base: git://linuxtv.org/media_tree.git master config: x86_64-randconfig-x011-201707 (attached as .config) compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 reproduce: # save the attached .config to linux build tree make ARCH=x86_64 Note: the linux-review/Sakari-Ailus/v4l-flash-led-class-Use-fwnode_handle-instead-of-device_node-in-init/20170213-213642 HEAD 339634e21fa74ca27c8dabeb794b47aad707eaa8 builds fine. It only hurts bisectibility. All errors (new ones prefixed by >>): drivers/media/v4l2-core/v4l2-flash-led-class.c: In function 'v4l2_flash_init':
quoted
drivers/media/v4l2-core/v4l2-flash-led-class.c:642:4: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
sd->fwnode = fwn ? fwn : device_fwnode_handle(led_cdev->dev);
^~
drivers/media/v4l2-core/v4l2-flash-led-class.c:642:27: error: implicit declaration of function 'device_fwnode_handle' [-Werror=implicit-function-declaration]
sd->fwnode = fwn ? fwn : device_fwnode_handle(led_cdev->dev);
^~~~~~~~~~~~~~~~~~~~
drivers/media/v4l2-core/v4l2-flash-led-class.c:642:25: warning: pointer/integer type mismatch in conditional expression
sd->fwnode = fwn ? fwn : device_fwnode_handle(led_cdev->dev);
^
drivers/media/v4l2-core/v4l2-flash-led-class.c:658:2: error: implicit declaration of function 'fwnode_handle_get' [-Werror=implicit-function-declaration]
fwnode_handle_get(sd->fwnode);
^~~~~~~~~~~~~~~~~
drivers/media/v4l2-core/v4l2-flash-led-class.c:658:22: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
fwnode_handle_get(sd->fwnode);
^~
drivers/media/v4l2-core/v4l2-flash-led-class.c:667:22: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
fwnode_handle_put(sd->fwnode);
^~
drivers/media/v4l2-core/v4l2-flash-led-class.c: In function 'v4l2_flash_release':
drivers/media/v4l2-core/v4l2-flash-led-class.c:687:22: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
fwnode_handle_put(sd->fwnode);
^~
cc1: some warnings being treated as errors
vim +642 drivers/media/v4l2-core/v4l2-flash-led-class.c
636
637 sd = &v4l2_flash->sd;
638 v4l2_flash->fled_cdev = fled_cdev;
639 v4l2_flash->iled_cdev = iled_cdev;
640 v4l2_flash->ops = ops;
641 sd->dev = dev;
> 642 sd->fwnode = fwn ? fwn : device_fwnode_handle(led_cdev->dev);
643 v4l2_subdev_init(sd, &v4l2_flash_subdev_ops);
644 sd->internal_ops = &v4l2_flash_subdev_internal_ops;
645 sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation Attachments
- .config.gz [application/gzip] 25827 bytes