Re: [PATCH] ARM: dts: armada-385-synology-ds116: add support for Synology DS116 NAS

Hello,

On Sun, 12 Feb 2017 16:38:55 +0100, Andrew Lunn wrote:

What you have in v2 and v3 looks good. It could be considered a bit of
a hack, two nodes for the same hardware block. But they are used at
different times, normal runtime, and late in the shutdown. So it works
out O.K.

I don't really mind personally, but IMO this is clearly a hack. It
completely violates the rule that the DT should represent the HW, and
the fact that the DT should be operating system agnostic.

But anyway, there are so many things in the DT that violates those
rules that probably this hack is fine.

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html