Thread (17 messages) 17 messages, 7 authors, 2017-02-27

Re: [PATCH 0/8] ARM: sun8i: a33: Mali improvements

From: Emil Velikov <hidden>
Date: 2017-02-26 14:15:59
Also in: dri-devel, linux-arm-kernel, linux-mm, lkml

Hi Maxime,

Thanks for the links.

On 24 February 2017 at 00:19, Maxime Ripard
[off-list ref] wrote:
Hi,

On Fri, Feb 17, 2017 at 08:39:33PM +0000, Emil Velikov wrote:
quoted
As I feared things have taken a turn for the bitter end :-]

It seems that this is a heated topic, so I'l kindly ask that we try
the following:

 - For people such as myself/Tobias/others who feel that driver and DT
bindings should go hand in hand, prove them wrong.
But please, do so by pointing to the documentation (conclusion of a
previous discussion). This way you don't have to repeat yourself and
get [too] annoyed over silly suggestions.
http://lxr.free-electrons.com/source/Documentation/devicetree/usage-model.txt#L13

"The "Open Firmware Device Tree", or simply Device Tree (DT), is a
data structure and language for describing hardware. More
specifically, it is a description of hardware that is readable by an
operating system so that the operating system doesn't need to hard
code details of the machine"

http://lxr.free-electrons.com/source/Documentation/devicetree/usage-model.txt#L79

"What it does do is provide a language for decoupling the hardware
configuration from the board and device driver support in the Linux
kernel (or any other operating system for that matter)."
The above seems to imply that there is (merged) device driver support
in the Linux kernel (or other) that uses the bindings.

It's not my call to make any of the policy, so I'll just kindly
suggest improving the existing documentation:
 - Reword/elaborate if out of tree [Linux or in general?] drivers are
suitable counterpart.
 - Patches could/should reference the "other OS" driver, or the "other
OS" name at least ?

Rather than clumping the above in 2.1 a separate section would be better ?
And like I said, we already had bindings for out of tree bindings,
like this one:
https://patchwork.kernel.org/patch/9275707/

Which triggered no discussion at the time (but the technical one,
hence a v2, that should always be done).
Needless to say, there's many of us waiting to see a Mali driver land
- hence the noise. It's not meant to belittle/sway the work you and
others do.
quoted
- The series has code changes which [seemingly] cater for out of tree
module(s).
That patch was dropped, only DT changes remains now, and do not depend
of that missing patch anyway.
quoted
Clearly state in the commit message who is the user, why it's save to
do so and get an Ack from more prominent [DRM] developers.
DRM is really not important here. We could implement a driver using
i2c as far as the DT is concerned.
What I meant to say is:

Please, provide clear expectations from the start - "Linux driver is
OOT with no ETA on landing" or "driver for $FOO OS is at $LINK".
Afaict Hans did the former in the patch mentioned. Perhaps you already
did - in which case pardon for missing it.
FreeBSD for example uses a different, !DRM framework to support our
display stack, and still uses the DT.
Interesting - do you have a link handy ? Does it use open-source usespace ?

Thanks
Emil

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help