On Thu, Feb 16, 2017 at 08:06:32PM +0100, Maxime Ripard wrote:

On Thu, Feb 16, 2017 at 01:48:46PM +0100, Corentin Labbe wrote:

quoted

This patch add pinctrl node for dwmac-sun8i on H3.

Signed-off-by: Corentin Labbe <redacted>
---
 arch/arm/boot/dts/sun8i-h3.dtsi | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/arch/arm/boot/dts/sun8i-h3.dtsi b/arch/arm/boot/dts/sun8i-h3.dtsi
index 61d56d2..59ed40e 100644
--- a/arch/arm/boot/dts/sun8i-h3.dtsi
+++ b/arch/arm/boot/dts/sun8i-h3.dtsi

@@ -349,6 +349,17 @@
 				function = "i2c2";
 			};
 
+			emac_rgmii_pins: emac0@0 {
+				allwinner,pins = "PD0", "PD1", "PD2", "PD3",
+						"PD4", "PD5", "PD7",
+						"PD8", "PD9", "PD10",
+						"PD12", "PD13", "PD15",
+						"PD16", "PD17";
+				allwinner,function = "emac";

Please use the generic pin config properties (ie. pins and functions).

quoted

+				allwinner,drive = <SUN4I_PINCTRL_40_MA>;

Why do you need to use 40mA?

quoted

+				allwinner,pull = <SUN4I_PINCTRL_NO_PULL>;

This is the default now.

Will fix that in all DT

Thanks
Corentin Labbe