Re: [PATCH v2 1/4] ARM: pwm: sun4i: unification of register operations for support sun6i.
From: Maxime Ripard <hidden>
Date: 2017-02-08 08:55:11
Also in:
linux-arm-kernel, linux-pwm, lkml
Hi, On Tue, Feb 07, 2017 at 08:50:43PM +0300, lis8215-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org wrote:
From: Siarhei Volkau <redacted> This patch not introduce new features, just prepare code for adding sun6i PWM driver in next commits. A31 SoC have a different map of PWM registers than others ASoCs, but register bits purposes are very similar. This patch introduce set of register access routines, which are common for existing in driver ASoCs: - ctl_rdy - checks the ready bit of specified PWM channel, - ctl_read - reads value from control register of specified PWM channel, - ctl_write - writes significant bits to control register of specified PWM channel, - prd_read - reads value from period register of specified PWM channel, - prd_write - writes value to period register of specified PWM channel. Driver code redesigned to use the new routines.
Why don't you use regmap for that? Thanks, Maxime -- Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com