Re: [PATCH 1/3] ARM: dts: Add support for phyCORE-AM335x PCM-953 carrier board

On Mon, Jan 23, 2017 at 4:27 AM, Teresa Remmet [off-list ref] wrote:

Hello Rob,

Am Samstag, den 21.01.2017, 14:53 -0600 schrieb Rob Herring:

quoted

On Thu, Jan 19, 2017 at 02:07:48PM +0100, Teresa Remmet wrote:

quoted

The phyCORE-AM335x development kit is a combination of the
phyCORE-AM335x SoM and a PCM-953 carrier board. The features
of the PCM-953 are:
* ETH phy on carrier board: 1x RGMII
* 1x CAN
* Up to 4x UART
* USB0 (otg)
* USB1 (host)
* SD slot
* User gpio-keys
* User LEDs

Signed-off-by: Teresa Remmet <t.remmet-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
Reviewed-by: Wadim Egorov <w.egorov-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
---
 .../devicetree/bindings/arm/omap/omap.txt          |   3 +
 arch/arm/boot/dts/Makefile                         |   1 +
 arch/arm/boot/dts/am335x-pcm-953.dtsi              | 303
+++++++++++++++++++++
 arch/arm/boot/dts/am335x-phycore-rdk.dts           |  27 ++
 4 files changed, 334 insertions(+)
 create mode 100644 arch/arm/boot/dts/am335x-pcm-953.dtsi
 create mode 100644 arch/arm/boot/dts/am335x-phycore-rdk.dts

[...]

quoted

+   user_leds: user_leds {
+           compatible = "gpio-leds";
+   };
+
+   user_buttons: user_buttons {
+           compatible = "gpio-keys";
+   };

With only a compatible, I don't think there's much gain to split
these 2
nodes. Otherwse,

whould it be ok to open up the root node again below? Or should I
better move the nodes up? Which does mess up the order then. We
orinented here on the am335x-pepper.dts. They also only keep the
compatibles in the root node.

The order is not important. It is silly to have the same node twice in
the same file. Someone should fix am335x-pepper.dts, too.

The split is generally what is chip specific and board specific, but
this is all board specific.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html