Re: Re: [PATCH v2 2/4] clk: sunxi-ng: add support for V3s CCU

2017年1月17日 17:04于 Maxime Ripard [off-list ref]写道：

Hi, 

On Tue, Jan 17, 2017 at 02:01:14AM +0800, Icenowy Zheng wrote: 

quoted

V3s has a similar but cut-down CCU to H3. 

Add support for it. 

Signed-off-by: Icenowy Zheng <redacted> 
--- 

Output from checkpatch: 
total: 5 errors, 2 warnings, 3 checks, 857 lines checked 

quoted

I think I should make a comparsion between V3s and H3 CCU here: 
(I won't mention the missing/added clocks here, only list conflicting clocks) 

That should be in your commit log. 

I think it can be easily get by a diff command :-)

And we do not have the tradition to describe clock difference in commit
log, is it right?

quoted

- "bus-ehci0" is at different bit (The bit that is "bus-ehci0" on V3s is 
  "bus-ehci2" on H3) 
- The mux of "ce" is different. (According the view at V3s datasheet by the 
  author of sun4i-ss, V3s may have sun4i-ss, not sun8i-ce) 
- The mux of "de" is different. (V3s do not have "pll-de", but it can mux "de" 
  to "pll-video") 
- Clocks about CSI largely differs. (As V3s is designed as a camera SoC, and 
  it have an extra "pll-isp") 

OK. 

Thanks, 
Maxime 

-- 
Maxime Ripard, Free Electrons 
Embedded Linux and Kernel engineering 
http://free-electrons.com 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group. 
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org 
For more options, visit https://groups.google.com/d/optout. 

-- 
You received this message because you are subscribed to the Google Groups "linux-sunxi" group.
To unsubscribe from this group and stop receiving emails from it, send an email to linux-sunxi+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.