Re: [PATCH] mtd: spi-nor: add dt support for Everspin MRAMs

On 16 January 2017 at 20:41, Uwe Kleine-König
[off-list ref] wrote:

On Mon, Jan 16, 2017 at 02:55:01PM +0100, Rafał Miłecki wrote:

quoted

On 16 January 2017 at 14:35, Uwe Kleine-König
[off-list ref] wrote:

quoted

The MR25 family doesn't support JEDEC, so they need explicit mentioning
in the list of supported spi IDs. This makes it possible to add these
using for example:

        compatible = "everspin,mr25h40";

Signed-off-by: Uwe Kleine-König <redacted>
---
Hello,

independent of the decision if -nonjedec is ok for m25p, this is needed
to make Everspin's MRAMs work.

Best regards
Uwe

 drivers/mtd/devices/m25p80.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
--- a/drivers/mtd/devices/m25p80.c
+++ b/drivers/mtd/devices/m25p80.c

@@ -305,6 +305,11 @@ static const struct spi_device_id m25p_ids[] = {
        {"m25p40-nonjedec"},    {"m25p80-nonjedec"},    {"m25p16-nonjedec"},
        {"m25p32-nonjedec"},    {"m25p64-nonjedec"},    {"m25p128-nonjedec"},

+       /* Everspin MRAMs without JEDEC support */
+       { "mr25h256" }, /* 256 kib, 40 MHz */

A trivial thing: I think it should be Kib
https://en.wikipedia.org/wiki/Binary_prefix

Oh, really? 10^3 = k and 2^10 = Ki, stange. Should I resend for that?

I don't think I understand you now. This is 262'144b device. You most
likely want to divide it by 1024 and use Kib then, right?

So it should be just 256 Kib instead of 256 kib.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html