Re: [alsa-devel] [PATCH v2 3/4] ASoC: rockchip: Add machine driver for ES8388 codecs
From: Daniel Baluta <hidden>
Date: 2017-01-16 10:27:31
Also in:
alsa-devel, linux-rockchip
Two nits, see below. <snip>
quoted hunk
+static int snd_rk_mc_probe(struct platform_device *pdev) +{ + int ret = 0; + struct snd_soc_card *card = &snd_soc_card_rk; + struct device_node *np = pdev->dev.of_node; + struct rk_es8388_drvdata *machine; + + machine = devm_kzalloc(&pdev->dev, sizeof(struct rk_es8388_drvdata), + GFP_KERNEL); +
You don't need this new line here.
quoted hunk
+ if (!machine) + return -ENOMEM; +
<snip>
quoted hunk
+module_platform_driver(snd_rk_es8388_driver); + +MODULE_AUTHOR("Sjoerd Simons");
You should also add your email address near name.
quoted hunk
+MODULE_DESCRIPTION("Rockchip es8388 machine ASoC driver"); +MODULE_LICENSE("GPL v2"); +MODULE_ALIAS("platform:" DRV_NAME);
thanks, Daniel. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html