Re: [PATCH 3/4] drivers/misc: Add ASpeed LPC control driver

On Thu, 2017-01-12 at 08:43 +0100, Greg KH wrote:

On Thu, Jan 12, 2017 at 11:29:09AM +1100, Cyril Bur wrote:

quoted

This driver exposes a reserved chunk of BMC ram to userspace as
well as
an ioctl interface to control the BMC<->HOST mapping of the LPC
bus.
This allows for a communication channel between the BMC and the
host

Why not make this a UIO driver?  Why does it have to be a character
device?

See my other email (looks like I'm getting things in reverse order
today ;-), basically it should just be some ioctl's, but what they do
should really be done by the kernel as it controls external access to
part of the chip physical address space.

Cheers,
Ben.

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html