Re: [PATCH 07/11] dt/bindings: da8xx-usb: Add binding for the cppi41 dma controller
From: Sergei Shtylyov <hidden>
Date: 2017-01-09 18:41:01
Also in:
linux-omap
Hello! On 01/09/2017 07:06 PM, Alexandre Bailon wrote:
DT binding for the TI DA8xx/OMAP-L1x/AM17xx/AM18xx cppi41 dma controller.
It's called CPPI 4.1, not cppi41. Let me introduce myself: I was the author of the 1st CPPI 4.1 drivers (never merged).
quoted hunk
Signed-off-by: Alexandre Bailon <abailon-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> --- .../devicetree/bindings/usb/da8xx-usb.txt | 39 ++++++++++++++++++++++ 1 file changed, 39 insertions(+)diff --git a/Documentation/devicetree/bindings/usb/da8xx-usb.txt b/Documentation/devicetree/bindings/usb/da8xx-usb.txt index ccb844a..2a4d737 100644 --- a/Documentation/devicetree/bindings/usb/da8xx-usb.txt +++ b/Documentation/devicetree/bindings/usb/da8xx-usb.txt@@ -18,10 +18,26 @@ Required properties:
[...]
quoted hunk
Optional properties: ~~~~~~~~~~~~~~~~~~~~ - vbus-supply: Phandle to a regulator providing the USB bus power. +DMA +~~~ +- compatible: ti,da8xx-cppi41 +- reg: offset and length of the following register spaces: USBSS, USB
I don't understand what you mean by USBSS and how it's related to CPPI 4.1.
+ CPPI DMA Controller, USB CPPI DMA Scheduler, USB Queue Manager
I'd drop "USB" everywhere, the DMAC scheduler and queue manager are not a part of any USB logic.
+- reg-names: glue, controller, scheduler, queuemgr
Quoted, maybe?
+- #dma-cells: should be set to 2. The first number represents the + endpoint number (0 … 3 for endpoints 1 … 4).
Not sure why you need EPs here. Is that required by the DMA driver? The DMA controller operates with channels... [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html