Re: [PATCH V2 3/3] cfg80211: support ieee80211-freq-limit DT property

On Mon, 2017-01-02 at 16:05 +0100, Rafał Miłecki wrote:

On 2 January 2017 at 15:04, Johannes Berg [off-list ref]
wrote:

quoted

Perhaps a better approach would be to not combine this with wiphy
registration, but require drivers that may use this to call a new
helper function *before* wiphy registration (and *after* calling
set_wiphy_dev()), like e.g.

   ieee80211_read_of_data(wiphy);

(...)

I just think it may be better to stick to something like
ieee80211_read_of_freq_limits
or
wiphy_read_of_freq_limits

I have no objection to that.

As you noted this function will be a bit specific because of
modifying (possibly shared) band channels. At some point we may want
to add more helpers for other OF properties which won't have extra
requirements for driver code. Some drivers may want to use them while
not necessary risking have shared band channels modified.

That makes sense, although at that time we might still wish to have a
common "read it all" with the combined requirements. But we can cross
that bridge when we get to it.

johannes