Re: [PATCH V2 1/3] cfg80211: allow passing struct device in the wiphy_new call

On 2 January 2017 at 14:38, Johannes Berg [off-list ref] wrote:

quoted

--- a/include/net/cfg80211.h
+++ b/include/net/cfg80211.h

@@ -3730,8 +3730,8 @@ static inline const char *wiphy_name(const

struct wiphy *wiphy)
  * Return: A pointer to the new wiphy. This pointer must be
  * assigned to each netdev's ieee80211_ptr for proper operation.
  */
-struct wiphy *wiphy_new_nm(const struct cfg80211_ops *ops, int
sizeof_priv,
-                        const char *requested_name);
+struct wiphy *wiphy_new_nm(struct device *dev, const struct
cfg80211_ops *ops,
+                        int sizeof_priv, const char
*requested_name);

This is obviously missing documentation updates.

quoted

  */
-static inline struct wiphy *wiphy_new(const struct cfg80211_ops
*ops,
+static inline struct wiphy *wiphy_new(struct device *dev,
+                                   const struct cfg80211_ops
*ops,

Ditto.

It looks like you practically removed all users of set_wiphy_dev(), why
not do that completely and remove that entirely?

There are 2 users left:
1) ipw2x00 - I missed that one
2) mac80211 - it's a big one as it's used in SET_IEEE80211_DEV

I was planning to work on mac80211 drivers later. This will require
similar modification of ieee80211_alloc_hw.

-- 
Rafał
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html