Thread (156 messages) 156 messages, 11 authors, 2017-07-31

Re: [PATCH v3 04/14] GPIO: Add gpio-ingenic driver

From: Linus Walleij <hidden>
Date: 2017-01-31 14:21:03
Also in: linux-fbdev, linux-gpio, linux-mips, linux-mmc, linux-pwm, lkml

Forgot to mention this:

On Wed, Jan 25, 2017 at 7:51 PM, Paul Cercueil [off-list ref] wrote:
This driver handles the GPIOs of all the Ingenic JZ47xx SoCs
currently supported by the upsteam Linux kernel.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
(...)
+       jzgc->gc.base = -1;
Nice
+       of_property_read_u32(dev->of_node, "base", &jzgc->gc.base);
Remove this. Dynamic allocation should be fine, if you're using the
new userspace ABI like tools/gpio/* or libgpiod and only that and in-kernel
consumers, dynamic numbers are just fine.

If you have old sysfs userspace that you need to support using the
global GPIO numberspace, please look into ways to phase that out.

Yours,
Linus Walleij
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help