Thread (4 messages) 4 messages, 3 authors, 2017-01-30

Re: [PATCH V2] ARM: dts: BCM5301X: Add missing Netgear R8000 LEDs and Keys

From: Florian Fainelli <f.fainelli@gmail.com>
Date: 2017-01-30 17:37:39
Also in: linux-arm-kernel, lkml

On 01/30/2017 01:08 AM, Aditya Xavier wrote:
Would you require me to send the revised Patch ?

Or would this do ?
Will take care of it this time.
And thanks for guiding me through this process :)

quoted
On 29-Jan-2017, at 2:45 AM, Rafał Miłecki [off-list ref] wrote:

On 28 January 2017 at 15:37, AdityaXavier [off-list ref] wrote:
quoted
From: Aditya Xavier <redacted>

Added two WAN status LEDs and a GPIO Key for Brightness which were missing.
V2: Updated subject, Power LED names, and WAN labels.
Changelog (V2 ... part) should go into that /comments/ section (see below).
Florian: can you drop that line when applying this patch? Otherwise it
looks OK to me.

quoted
Signed-off-by: Aditya Xavier <redacted>
Acked-by: Rafał Miłecki <rafal@milecki.pl>

Thanks for the patch!

quoted
---
Right here, below these 3 dashes is a place where you can add extra
comments (they won't go into log when doing "git am").
quoted
arch/arm/boot/dts/bcm4709-netgear-r8000.dts | 22 ++++++++++++++++++++--
1 file changed, 20 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
index 92f8a72..90d4420 100644
--- a/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
+++ b/arch/arm/boot/dts/bcm4709-netgear-r8000.dts
@@ -27,18 +27,30 @@
       leds {
               compatible = "gpio-leds";

-               power0 {
+               power-white {
                       label = "bcm53xx:white:power";
                       gpios = <&chipcommon 2 GPIO_ACTIVE_LOW>;
                       linux,default-trigger = "default-on";
               };

-               power1 {
+               power-amber {
                       label = "bcm53xx:amber:power";
                       gpios = <&chipcommon 3 GPIO_ACTIVE_LOW>;
                       linux,default-trigger = "default-off";
               };

+               wan-white {
+                       label = "bcm53xx:white:wan";
+                       gpios = <&chipcommon 8 GPIO_ACTIVE_LOW>;
+                       linux,default-trigger = "default-on";
+               };
+
+               wan-amber {
+                       label = "bcm53xx:amber:wan";
+                       gpios = <&chipcommon 9 GPIO_ACTIVE_HIGH>;
+                       linux,default-trigger = "default-off";
+               };
+
               5ghz-1 {
                       label = "bcm53xx:white:5ghz-1";
                       gpios = <&chipcommon 12 GPIO_ACTIVE_LOW>;
@@ -104,6 +116,12 @@
                       linux,code = <KEY_RESTART>;
                       gpios = <&chipcommon 6 GPIO_ACTIVE_LOW>;
               };
+
+               brightness {
+                       label = "Backlight";
+                       linux,code = <KEY_BRIGHTNESS_ZERO>;
+                       gpios = <&chipcommon 19 GPIO_ACTIVE_LOW>;
+               };
       };
};

--
2.9.3


-- 
Rafał

-- 
Florian

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help