On Tue, Jan 24, 2017 at 09:22:24AM +0100, Ulf Hansson wrote:

On 16 January 2017 at 17:56, Maxime Ripard
[off-list ref] wrote:

quoted

Add a bit more debug messages that can be helpful when debugging the clock
setup.

Signed-off-by: Maxime Ripard <redacted>
---
 drivers/mmc/host/sunxi-mmc.c | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
index f0f6922bca8a..40ed287ceb1c 100644
--- a/drivers/mmc/host/sunxi-mmc.c
+++ b/drivers/mmc/host/sunxi-mmc.c

@@ -661,6 +661,9 @@ static int sunxi_mmc_oclk_onoff(struct sunxi_mmc_host *host, u32 oclk_en)
        unsigned long expire = jiffies + msecs_to_jiffies(750);
        u32 rval;

+       dev_dbg(mmc_dev(host->mmc), "%sabling the clock\n",
+               oclk_en ? "en" : "dis");
+
        rval = mmc_readl(host, REG_CLKCR);
        rval &= ~(SDXC_CARD_CLOCK_ON | SDXC_LOW_POWER_ON | SDXC_MASK_DATA0);

@@ -737,6 +740,7 @@ static int sunxi_mmc_clk_set_phase(struct sunxi_mmc_host *host,
                        index = SDXC_CLK_50M_DDR;
                }
        } else {
+               dev_dbg(mmc_dev(host->mmc), "Invalid clock... returning\n");
                return -EINVAL;
        }

@@ -753,6 +757,9 @@ static int sunxi_mmc_clk_set_rate(struct sunxi_mmc_host *host,
        u32 rval, clock = ios->clock;
        int ret;

+       dev_dbg(mmc_dev(host->mmc), "setting clk to %u (requested %u)\n",
+               clock, ios->clock);
+

A better option is to update mmc->actual_clock. That value is
available (and the requested value) though the debugFS nodes.

Ok, I will change that.

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com