Re: [PATCH 1/2] Documentation: devicetree: Add i2c binding for mediatek MT2701 Soc Platform
From: Matthias Brugger <matthias.bgg@gmail.com>
Date: 2017-01-24 15:03:31
Also in:
linux-arm-kernel, linux-i2c, linux-mediatek, lkml
On 01/18/2017 07:07 AM, Jun Gao wrote:
quoted hunk
From: Jun Gao <redacted> This add i2c DT binding to i2c-mt6577.txt for MT2701. Signed-off-by: Jun Gao <redacted> --- .../devicetree/bindings/i2c/i2c-mt6577.txt | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt index 0ce6fa3..ef22ecf 100644 --- a/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt +++ b/Documentation/devicetree/bindings/i2c/i2c-mt6577.txt@@ -4,11 +4,12 @@ The Mediatek's I2C controller is used to interface with I2C devices. Required properties: - compatible: value should be either of the following. - (a) "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c. - (b) "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c. - (c) "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c. - (d) "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c. - (e) "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c. + "mediatek,mt2701-i2c", for i2c compatible with mt2701 i2c. + "mediatek,mt6577-i2c", for i2c compatible with mt6577 i2c. + "mediatek,mt6589-i2c", for i2c compatible with mt6589 i2c. + "mediatek,mt8127-i2c", for i2c compatible with mt8127 i2c. + "mediatek,mt8135-i2c", for i2c compatible with mt8135 i2c. + "mediatek,mt8173-i2c", for i2c compatible with mt8173 i2c. - reg: physical base address of the controller and dma base, length of memory mapped region. - interrupts: interrupt number to the cpu.
Actually what you need for mt2701 is what you put into the dts file: compatible = "mediatek,mt2701-i2c", "mediatek,mt6577-i2c"; "mediatek,mt2701-i2c" alone is not supported in the driver. While at it would you mind to fix the bindings description for the other SoCs as well? Thanks, Matthias