On Sat, Jan 21, 2017 at 8:50 PM, Chunfeng Yun [off-list ref] wrote:

On Sat, 2017-01-21 at 14:08 -0600, Rob Herring wrote:

quoted

On Wed, Jan 18, 2017 at 02:00:14PM +0800, Chunfeng Yun wrote:

quoted

add a new compatible string for "mt2712", and a new reference clock
for SuperSpeed analog phy;

Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
---
 .../devicetree/bindings/phy/phy-mt65xx-usb.txt     |   81 +++++++++++++++++---
 1 file changed, 70 insertions(+), 11 deletions(-)

[...]

quoted

quoted

@@ -31,21 +37,27 @@ Example:
 u3phy: usb-phy@11290000 {
    compatible = "mediatek,mt8173-u3phy";
    reg = <0 0x11290000 0 0x800>;
-   clocks = <&apmixedsys CLK_APMIXED_REF2USB_TX>;
-   clock-names = "u3phya_ref";
+   clocks = <&apmixedsys CLK_APMIXED_REF2USB_TX>, <&clk26m>;
+   clock-names = "u2ref_clk", "u3ref_clk";
    #address-cells = <2>;
    #size-cells = <2>;
    ranges;
    status = "okay";

-   phy_port0: port@11290800 {
-           reg = <0 0x11290800 0 0x800>;
+   u2port0: port@11290800 {

port is for OF graph. This should be usb-phy@... instead.

Is there any problems if u2port0's name@addr is the same as its parent's
(u3phy)?  as following:
        u3phy: usb-phy@11290000 {
                compatible = ...;
                // no reg property
                clocks = ...;
                u2port0: usb-phy@11290000 {
                        reg = ...;
        }

No problem, that is fine.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html