On 18 January 2017 at 08:50, Matt Ranostay [off-list ref] wrote:

On Sun, Jan 15, 2017 at 6:35 PM, Shawn Lin [off-list ref] wrote:

quoted

On 2017/1/16 5:41, Matt Ranostay wrote:

quoted

On Thu, Jan 12, 2017 at 11:16 PM, Shawn Lin [off-list ref]
wrote:

quoted

On 2017/1/13 13:29, Matt Ranostay wrote:

quoted

Allow power sequencing for the Marvell SD8787 Wifi/BT chip.
This can be abstracted to other chipsets if needed in the future.

Cc: Tony Lindgren <redacted>
Cc: Ulf Hansson <redacted>
Signed-off-by: Matt Ranostay <redacted>
---
 drivers/mmc/core/Kconfig         |  10 ++++
 drivers/mmc/core/Makefile        |   1 +
 drivers/mmc/core/pwrseq_sd8787.c | 117
+++++++++++++++++++++++++++++++++++++++
 3 files changed, 128 insertions(+)
 create mode 100644 drivers/mmc/core/pwrseq_sd8787.c

diff --git a/drivers/mmc/core/Kconfig b/drivers/mmc/core/Kconfig
index cdfa8520a4b1..fc1ecdaaa9ca 100644
--- a/drivers/mmc/core/Kconfig
+++ b/drivers/mmc/core/Kconfig

@@ -12,6 +12,16 @@ config PWRSEQ_EMMC
          This driver can also be built as a module. If so, the module
          will be called pwrseq_emmc.

+config PWRSEQ_SD8787
+       tristate "HW reset support for SD8787 BT + Wifi module"
+       depends on OF && (MWIFIEX || BT_MRVL_SDIO)
+       help
+         This selects hardware reset support for the SD8787 BT + Wifi
+         module. By default this option is set to n.
+
+         This driver can also be built as a module. If so, the module
+         will be called pwrseq_sd8787.
+

I don't like this way, as we have a chance to list lots
configure options here. wifi A,B,C,D...Z, all of them need a
new section here if needed?

Instead, could you just extent pwrseq_simple.c and add you
.compatible = "mmc-pwrseq-sd8787", "mmc-pwrseq-simple"?

You mean all the chipset pwrseqs linked into the pwrseq-simple module?

What I mean was if you just extent the pwrseq-simple a bit, you could
just add your chipset pwrseqs linked into the pwrseq-simple. But if you
need a different *pattern* of pwrseqs, you should need a new name, for
instance, pwrseq-sdio.c etc... But please don't use the name of
sd8787? So if I use a wifi named ABC but using the same pwrseq pattenr,
should I include your "mmc-pwrseq- sd8787" for that or I need a new
mmc-pwrseq-ABC.c?

Ah so pwrseq-sdio.c seems reasonable and having chipsets functions
defined in a structure. That could be abstracted out for other
chipsets that could needed in the future.

I think get the idea and it seems reasonable. With that in mind, I
have looked at the code once more and I got some new ideas on how to
adopt pwrseq-simple for your case.

I post the comments separately.

Kind regards
Uffe
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html