Re: [PATCH v8 3/3] arm64: dts: exynos: Add support for S6E3HA2 panel device on TM2 board

2017년 01월 11일 16:46에 Andrzej Hajda 이(가) 쓴 글:

On 11.01.2017 07:33, Hoegeun Kwon wrote:

quoted

From: Hyungwon Hwang <redacted>

This patch add the panel device tree node for S6E3HA2 display
controller to TM2 dts.

Signed-off-by: Hyungwon Hwang <redacted>
Signed-off-by: Andrzej Hajda <redacted>
Signed-off-by: Chanwoo Choi <redacted>
Signed-off-by: Hoegeun Kwon <redacted>
Tested-by: Chanwoo Choi <redacted>
---
 arch/arm64/boot/dts/exynos/exynos5433-tm2.dts | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
index ddba2f8..6d362f9 100644
--- a/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts
+++ b/arch/arm64/boot/dts/exynos/exynos5433-tm2.dts

@@ -18,6 +18,18 @@
 	compatible = "samsung,tm2", "samsung,exynos5433";
 };
 
+&dsi {
+	panel@0 {
+		compatible = "samsung,s6e3ha2";
+		reg = <0>;
+		vdd3-supply = <&ldo27_reg>;
+		vci-supply = <&ldo28_reg>;
+		reset-gpios = <&gpg0 0 GPIO_ACTIVE_LOW>;
+		enable-gpios = <&gpf1 5 GPIO_ACTIVE_HIGH>;
+		te-gpios = <&gpf1 3 GPIO_ACTIVE_HIGH>;

The same here (as in 1st comment) , te-gpios should be dropper - decon
uses hw-trigger.

Reasonable to remove te-gpios property but this change would make MIPI-DSI driver probing to be failed so MIPI-DSI driver should be fixed together.

Thanks.

Regards
Andrzej

quoted

+	};
+};
+
 &hsi2c_9 {
 	status = "okay";
 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html