Re: [PATCH 2/4] input: tm2-touchkey: Add touchkey driver support for TM2
From: Krzysztof Kozlowski <krzk@kernel.org>
Date: 2017-01-03 17:00:09
Also in:
linux-arm-kernel, linux-input, linux-samsung-soc, lkml
On Tue, Jan 03, 2017 at 04:57:15PM +0900, Jaechul Lee wrote:
quoted hunk ↗ jump to hunk
This patch adds support for the TM2 touch key and led functionlity. The driver interfaces with userspace through an input device and reports KEY_PHONE and KEY_BACK event types. LED brightness can be controlled by "/sys/class/leds/tm2-touchkey/brightness". Signed-off-by: Jaechul Lee <redacted> Signed-off-by: Beomho Seo <redacted> --- drivers/input/keyboard/Kconfig | 11 ++ drivers/input/keyboard/Makefile | 1 + drivers/input/keyboard/tm2-touchkey.c | 326 ++++++++++++++++++++++++++++++++++ 3 files changed, 338 insertions(+) create mode 100644 drivers/input/keyboard/tm2-touchkey.cdiff --git a/drivers/input/keyboard/Kconfig b/drivers/input/keyboard/Kconfig index cbd75cf..72c0ba1 100644 --- a/drivers/input/keyboard/Kconfig +++ b/drivers/input/keyboard/Kconfig@@ -666,6 +666,17 @@ config KEYBOARD_TC3589X To compile this driver as a module, choose M here: the module will be called tc3589x-keypad. +config KEYBOARD_TM2_TOUCHKEY + tristate "tm2-touchkey support" + depends on I2C + help + Say Y here to enable the tm2-touchkey.
The ending full stop is not needed.
+ touchkey driver for tm2. This driver can enable + the interrupt and make input events and control led brightness.
This sentence needs improvements. How about just: "Beside input device, this driver provides also brightness control for LEDs on touch keys." Best regards, Krzysztof