Re: [PATCH net-next v2] dsa:mv88e6xxx: dispose irq mapping for chip->irq

On Wed, Dec 07, 2016 at 05:40:12PM +0100, Volodymyr Bendiuga wrote:

Yes, most of the users of of_irq_get() do not use irq_dispose_mapping().

But some of them do (some irq chips), and I believe the correct way
of doing this is to

dispose irq mapping, as the description for this function says that
it unmaps

the irq, which is mapped by of_irq_parse_and_map(). Not disposing
irq might not make

any affect on most drivers, but some, that get EPROBE_DEFER error do
need to dispose.

This is what I get when I run the code.

of_irq_put() could be implemented, and it would be a wrapper for
irq_dispose_mapping()

as I can see it. Should I do it this way?

Hi Volodymyr

Yes, i think having of_irq_put() would be good. It gives some symmetry
to the API.

   Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html