Thread (22 messages) 22 messages, 4 authors, 2017-01-07

Re: [PATCH v3 1/4] dt-bindings: phy: Add support for QUSB2 phy

From: Vivek Gautam <hidden>
Date: 2016-12-28 05:41:25
Also in: linux-arm-msm, lkml

On Wed, Dec 28, 2016 at 6:43 AM, Stephen Boyd [off-list ref] wrote:
On 12/22/2016 08:52 PM, Vivek Gautam wrote:
quoted
quoted
quoted
+
+Optional properties:
+ - nvmem-cells: a list of phandles to nvmem cells that contain fused
+             tuning parameters for qusb2 phy, one for each entry
+             in nvmem-cell-names.
+ - nvmem-cell-names: must be "tune2_hstx_trim" for cell containing
+                  HS Tx trim value.
ditto.
nvmem doesn't allow, at this point, to get the cells by index.
Its APIs take 'const char' cell id and get the cell.

We should add this support to get the cell by index.
Will create a patch for that, and drop the '-names' property from bindings.
If we introduce a cells based API just for this case of one phandle it
may make sense to allow the cell id to be NULL and default to whatever
cell is there without a names property. We do something similar with
clks where a NULL connection id defaults to the first phandle in the
list. Then we can avoid having a new set of DT specific APIs here. Of
course, documentation should be updated to indicate that a NULL cell_id
means use index 0 with DT.
Right. This makes sense. I didn't notice that we do something
similar in clocks.
I will post a new change for this (which should be pretty small
in comparison to earlier patchset that introduced new dt based APIs).
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help