Thread (9 messages) 9 messages, 3 authors, 2016-12-15

Re: [PATCH v4 2/6] [media] rc-main: split setup and unregister functions

From: Andi Shyti <hidden>
Date: 2016-12-15 16:26:42
Also in: linux-leds, linux-media, lkml

quoted
+	/* rc_open will be called here */
+	rc = input_register_device(dev->input_dev);
+	if (rc)
+		goto out_table;
+
+	dev->input_dev->dev.parent = &dev->dev;
+	memcpy(&dev->input_dev->id, &dev->input_id, sizeof(dev->input_id));
+	dev->input_dev->phys = dev->input_phys;
+	dev->input_dev->name = dev->input_name;
I was testing your changes, and with this patch none of my rc devices
have input devices associated with them. The problem is that you've changed
the order: input_register_device() should happen AFTER the preceding
4 lines.
This must have been a copy paste error and I don't have
transmitters to test it. Thanks for testing it. I will send it
again.

Andi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help