Re: [PATCH v6 1/2] Add OV5647 device tree documentation
From: Pavel Machek <hidden>
Date: 2016-12-13 19:08:05
Also in:
linux-media, lkml
On Tue 2016-12-13 14:32:36, Ramiro Oliveira wrote:
quoted hunk ↗ jump to hunk
Create device tree bindings documentation. Signed-off-by: Ramiro Oliveira <redacted> --- .../devicetree/bindings/media/i2c/ov5647.txt | 35 ++++++++++++++++++++++ 1 file changed, 35 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/i2c/ov5647.txtdiff --git a/Documentation/devicetree/bindings/media/i2c/ov5647.txt b/Documentation/devicetree/bindings/media/i2c/ov5647.txt new file mode 100644 index 0000000..46e5e30 --- /dev/null +++ b/Documentation/devicetree/bindings/media/i2c/ov5647.txt@@ -0,0 +1,35 @@ +Omnivision OV5647 raw image sensor +--------------------------------- + +OV5647 is a raw image sensor with MIPI CSI-2 and CCP2 image data interfaces +and CCI (I2C compatible) control bus. + +Required properties: + +- compatible : "ovti,ov5647"; +- reg : I2C slave address of the sensor; +- clocks : Reference to the xclk clock. +- clock-names : Should be "xclk". +- clock-frequency: Frequency of the xclk clock
Nit pick: you end the lines here with ';', '.' and nothing. Pick one :-). Otherwise it looks good. Acked-by: Pavel Machek <redacted> Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Attachments
- signature.asc [application/pgp-signature] 181 bytes