Thread (15 messages) 15 messages, 4 authors, 2016-12-12

Re: [PATCH v5 2/5] i2c: Add STM32F4 I2C driver

From: Wolfram Sang <hidden>
Date: 2016-12-11 21:42:39
Also in: linux-arm-kernel, linux-i2c, lkml

Hi,
+config I2C_STM32F4
+	tristate "STMicroelectronics STM32F4 I2C support"
+	depends on ARCH_STM32  || COMPILE_TEST
Double space.
+#define STM32F4_I2C_MIN_FREQ		2
+#define STM32F4_I2C_MAX_FREQ		42
Those two must be unsigned to fix the build error (e.g. 2U) reported by
build-bot.

Also, I get the following build warnings:

  CC      drivers/i2c/busses/i2c-stm32f4.o
drivers/i2c/busses/i2c-stm32f4.c: In function ‘stm32f4_i2c_handle_rx_addr’:
drivers/i2c/busses/i2c-stm32f4.c:445:6: warning: variable ‘sr2’ set but not used [-Wunused-but-set-variable]
  u32 sr2;
      ^~~
drivers/i2c/busses/i2c-stm32f4.c: In function ‘stm32f4_i2c_isr_event’:
drivers/i2c/busses/i2c-stm32f4.c:496:41: warning: variable ‘sr2’ set but not used [-Wunused-but-set-variable]
  u32 real_status, possible_status, ien, sr2;

I assume those are reads to clear the register, so we really don't need
to save the value in a variable.

Rest is looking good.

Thanks,

   Wolfram

Attachments

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help