Hi Rob,

Thanks for reviewing

On 11/30/2016 09:53 PM, Rob Herring wrote:

On Thu, Nov 24, 2016 at 03:45:44PM +0100, gabriel.fernandez@st.com wrote:

quoted

From: Gabriel Fernandez <redacted>

This patch introduces lcd-tft clock for stm32f4 soc.

Signed-off-by: Gabriel Fernandez <redacted>
---
  .../devicetree/bindings/clock/st,stm32-rcc.txt     |   1 +
  drivers/clk/clk-stm32f4.c                          | 118 +++++++++++++++++++++
  include/dt-bindings/clock/stm32f4-clock.h          |   3 +-
  3 files changed, 121 insertions(+), 1 deletion(-)

quoted

diff --git a/include/dt-bindings/clock/stm32f4-clock.h b/include/dt-bindings/clock/stm32f4-clock.h
index 56b8e10..1be4a3a 100644
--- a/include/dt-bindings/clock/stm32f4-clock.h
+++ b/include/dt-bindings/clock/stm32f4-clock.h

@@ -27,7 +27,8 @@
  #define CLK_RTC			5
  #define PLL_VCO_I2S		6
  #define PLL_VCO_SAI		7
+#define CLK_LCD			8
  
-#define END_PRIMARY_CLK		8
+#define END_PRIMARY_CLK		9

Do you really need this? Having this change could cause compatibility
problems between dtb and kernel versions.

Please restructure the patch series and put all of the binding changes
including this header into a single patch. Incrementally add s/w
features, not h/w.

Rob

Okay

Best Regards

Gabriel