Re: [PATCH v3 4/4] [media] dt-bindings: add TI VPIF documentation
From: Rob Herring <hidden>
Date: 2016-11-28 21:38:22
Also in:
linux-media
On Tue, Nov 22, 2016 at 07:52:44AM -0800, Kevin Hilman wrote:
quoted hunk
Signed-off-by: Kevin Hilman <khilman-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> --- .../bindings/media/ti,da850-vpif-capture.txt | 65 ++++++++++++++++++++++ .../devicetree/bindings/media/ti,da850-vpif.txt | 8 +++ 2 files changed, 73 insertions(+) create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt create mode 100644 Documentation/devicetree/bindings/media/ti,da850-vpif.txtdiff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt new file mode 100644 index 000000000000..c447ac482c1d --- /dev/null +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif-capture.txt@@ -0,0 +1,65 @@ +Texas Instruments VPIF Capture +------------------------------ + +The TI Video Port InterFace (VPIF) capture component is the primary +component for video capture on the DA850 family of TI DaVinci SoCs. + +TI Document number reference: SPRUH82C + +Required properties: +- compatible: must be "ti,da850-vpif-capture" +- reg: physical base address and length of the registers set for the device; +- interrupts: should contain IRQ line for the VPIF + +VPIF capture has a 16-bit parallel bus input, supporting 2 8-bit +channels or a single 16-bit channel. It should contain at least one +port child node with child 'endpoint' node. Please refer to the +bindings defined in +Documentation/devicetree/bindings/media/video-interfaces.txt. + +Example using 2 8-bit input channels, one of which is connected to an +I2C-connected TVP5147 decoder: + + vpif_capture: video-capture@0x00217000 {
Drop the 0x00.
+ compatible = "ti,da850-vpif-capture";
+ reg = <0x00217000 0x1000>;
+ interrupts = <92>;
+
+ port {
+ vpif_ch0: endpoint@0 {
+ reg = <0>;This is missing #size-cells and #addr-cells.
+ bus-width = <8>;
+ remote-endpoint = <&composite>;
+ };
+
+ vpif_ch1: endpoint@1 {I think probably channels here should be ports rather than endpoints. AIUI, having multiple endpoints is for cases like a mux or 1 to many connections. There's only one data flow, but multiple sources or sinks.
quoted hunk
+ reg = <1>; + bus-width = <8>; + data-shift = <8>; + }; + }; + }; + +[ ... ] + +&i2c0 { + + tvp5147@5d { + compatible = "ti,tvp5147"; + reg = <0x5d>; + status = "okay"; + + port { + composite: endpoint { + hsync-active = <1>; + vsync-active = <1>; + pclk-sample = <0>; + + /* VPIF channel 0 (lower 8-bits) */ + remote-endpoint = <&vpif_ch0>; + bus-width = <8>; + }; + }; + }; + +};diff --git a/Documentation/devicetree/bindings/media/ti,da850-vpif.txt b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt new file mode 100644 index 000000000000..d004e600aabe --- /dev/null +++ b/Documentation/devicetree/bindings/media/ti,da850-vpif.txt@@ -0,0 +1,8 @@ +Texas Instruments VPIF +---------------------- + +The Video Port InterFace (VPIF) is the core component for video output +and capture on DA850 TI Davinci SoCs. + +- compatible: must be "ti,da850-vpif" +- reg: physical base address and length of the registers set for the device;
That's it? How does this block relate to the capture block? Rob -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html