Re: [PATCH v2 08/13] net: ethernet: ti: cpts: move dt props parsing to cpts driver
From: Grygorii Strashko <grygorii.strashko@ti.com>
Date: 2016-11-29 15:54:40
Also in:
linux-omap, lkml, netdev
On 11/29/2016 04:11 AM, Richard Cochran wrote:
On Mon, Nov 28, 2016 at 05:03:32PM -0600, Grygorii Strashko wrote:quoted
+static int cpts_of_parse(struct cpts *cpts, struct device_node *node) +{ + int ret = -EINVAL; + u32 prop; + + if (of_property_read_u32(node, "cpts_clock_mult", &prop)) + goto of_error; + cpts->cc_mult = prop;Why not set cc.mult here at the same time?
The same reason as in prev patch - cpts->cc_mult is original/initial mult value loaded from DT (or calculated), while cc.mult is dynamic value which can be changed as part of freq adjustment.
quoted
+ + if (of_property_read_u32(node, "cpts_clock_shift", &prop)) + goto of_error; + cpts->cc.shift = prop; + + return 0; + +of_error: + dev_err(cpts->dev, "CPTS: Missing property in the DT.\n"); + return ret; +}
-- regards, -grygorii