Re: [PATCH V4 1/2] pinctrl: tegra: Add DT binding for io pads control
From: Jon Hunter <hidden>
Date: 2016-11-25 17:22:55
Also in:
linux-gpio, linux-tegra, lkml
On 24/11/16 08:38, Laxman Dewangan wrote:
NVIDIA Tegra124 and later SoCs support the multi-voltage level and low power state of some of its IO pads. The IO pads can work in the voltage of the 1.8V and 3.3V of IO voltage from IO power rail sources.
Can you fix the above sentence?
quoted hunk ↗ jump to hunk
When IO interfaces are not used then IO pads can be configure in low power state to reduce the power consumption from that IO pads. On Tegra124, the voltage level of IO power rail source is auto detected by hardware(SoC) and hence it is only require to configure in low power mode if IO pads are not used. On T210 onwards, the auto-detection of voltage level from IO power rail is removed from SoC and hence SW need to configure the PMC register explicitly to set proper voltage in IO pads based on IO rail power source voltage. Add DT binding document for detailing the DT properties for configuring IO pads voltage levels and its power state. Signed-off-by: Laxman Dewangan <redacted> --- Changes from V1: New in series based on pinctrl driver requirement. Changes from V2: Updated the statement to say 1.8V and 3.3V as nominal voltage. Corrected DT example by adding -supply and taken care of V1 review from Rob. .../bindings/pinctrl/nvidia,tegra-io-pad.txt | 126 +++++++++++++++++++++ 1 file changed, 126 insertions(+) create mode 100644 Documentation/devicetree/bindings/pinctrl/nvidia,tegra-io-pad.txtdiff --git a/Documentation/devicetree/bindings/pinctrl/nvidia,tegra-io-pad.txt b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra-io-pad.txt new file mode 100644 index 0000000..a88c484 --- /dev/null +++ b/Documentation/devicetree/bindings/pinctrl/nvidia,tegra-io-pad.txt@@ -0,0 +1,126 @@ +NVIDIA Tegra PMC IO pad controller + +NVIDIA Tegra124 and later SoCs support the multi-voltage level and low power +state of some of its IO pads. When IO interface are not used then IO pads can +be configure in low power state to reduce the power from that IO pads. The IO +pads can work in the nominal IO voltage of 1.8V and 3.3V from power rail +sources.
I would replace the above sentence with ... "The IO pads can operate at the nominal IO voltage of either 1.8V or 3.3V". Cheers Jon -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html