Thread (7 messages) 7 messages, 4 authors, 2016-11-07

Re: [PATCH] ARM: tegra: nyan: Enable GPU node and related supply

From: Jon Hunter <jonathanh@nvidia.com>
Date: 2016-11-07 13:00:21
Also in: linux-arm-kernel, linux-tegra, lkml

Thierry,

On 07/11/16 12:51, Alexandre Courbot wrote:
On Wed, Sep 21, 2016 at 4:57 PM, Jon Hunter [off-list ref] wrote:
quoted
On 20/09/16 19:17, Paul Kocialkowski wrote:
quoted
* PGP Signed by an unknown key

Le mardi 20 septembre 2016 à 13:24 +0100, Jon Hunter a écrit :
quoted
On 18/09/16 15:13, Paul Kocialkowski wrote:
quoted
This enables the GPU node for tegra124 nyan boards, which is required to
get graphics acceleration with nouveau on these devices.

Signed-off-by: Paul Kocialkowski <redacted>
---
 arch/arm/boot/dts/tegra124-nyan.dtsi | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/tegra124-nyan.dtsi
b/arch/arm/boot/dts/tegra124-nyan.dtsi
index dab9509..225ca77 100644
--- a/arch/arm/boot/dts/tegra124-nyan.dtsi
+++ b/arch/arm/boot/dts/tegra124-nyan.dtsi
@@ -42,6 +42,12 @@
            };
    };

+   gpu@0,57000000 {
+           status = "okay";
+
+           vdd-supply = <&vdd_gpu>;
+   };
+
    serial@70006000 {
            /* Debug connector on the bottom of the board near SD card.
*/
            status = "okay";
@@ -214,7 +220,7 @@
                                    regulator-always-on;
                            };

-                           sd6 {
+                           vdd_gpu: sd6 {
                                    regulator-name = "+VDD_GPU_AP";
                                    regulator-min-microvolt = <650000>;
                                    regulator-max-microvolt =
<1200000>;
Looks good to me. I see the following error when booting but looking at the
code appears to be benign. Thierry, Alex, is this normal/okay?
I have the same messages and asked Alexandre about them the other day. He told
me that it looks normal.
Ok great. Hopefully, Alex can ACK then.
Apologies for the (very) delayed reply.

Yes, the messages you are seeing are part of the normal probe sequence
on Tegra. So this looks good to me.

Acked-by: Alexandre Courbot <acourbot@nvidia.com>
Can you pick this one up for v4.10 as well?

Cheers
Jon

-- 
nvpublic
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help