Re: [PATCH v2 1/6] pinctrl-aspeed-g5: Never set SCU90[6]
From: Linus Walleij <hidden>
Date: 2016-11-07 09:32:40
Also in:
linux-arm-kernel, linux-gpio, lkml
From: Linus Walleij <hidden>
Date: 2016-11-07 09:32:40
Also in:
linux-arm-kernel, linux-gpio, lkml
On Wed, Nov 2, 2016 at 3:37 PM, Andrew Jeffery [off-list ref] wrote:
If a pin depending on bit 6 in SCU90 is requested for GPIO, the export will succeed but changes to the GPIO's value will not be accepted by the hardware. This is because the pinmux driver has misconfigured the SCU by writing 1 to the reserved bit. The description of SCU90[6] from the datasheet is 'Reserved, must keep at value ”0”'. The fix is to switch pinmux from the bit-flipping macro to explicitly configuring the .enable and .disable values to zero. The patch has been tested on an AST2500 EVB. Fixes: 56e57cb6c07f (pinctrl: Add pinctrl-aspeed-g5 driver) Reported-by: Uma Yadlapati <redacted> Signed-off-by: Andrew Jeffery <redacted> --- This patch should be applied for 4.9.
Patch applied for fixes, adding Joel's review tag. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel