Re: [PATCH v3 5/6] Documentation: bindings: add documentation for ir-spi device driver
From: Andi Shyti <hidden>
Date: 2016-11-04 04:28:43
Also in:
linux-leds, linux-media, lkml
Hi Jacek,
quoted
quoted
Only DT bindings of LED class drivers should be placed in Documentation/devicetree/bindings/leds. Please move it to the media bindings.that's where I placed it first, but Rob asked me to put it in the LED directory and Cc the LED mailining list. That's the discussion of the version 2: https://lkml.org/lkml/2016/9/12/380 Rob, Jacek, could you please agree where I can put the binding?I'm not sure if this is a good approach. I've noticed also that backlight bindings have been moved to leds, whereas they don't look similarly. We have common.txt LED bindings, that all LED class drivers' bindings have to follow. Neither backlight bindings nor these ones do that, which introduces some mess. Eventually adding a sub-directory, e.g. remote_control could make it somehow logically justified, but still - shouldn't bindings be placed in the documentation directory related to the subsystem of the driver they are predestined to?
In principle I agree with you, also because I understood that the led kind of bindings are for those LEDs which main function is to emit light. There is no need for a remote control directory, because there is one already under bindings/media, where all the remote controllers are placed. Now this is a matter of interpretation, is this an IR LED used by the driver as remote controller or is this a remote controller with just an IR LED? In any case, I will wait for you and Rob to agree where is best to place the binding, then I will send a new version. Thanks, Andi