Re: [PATCH v2 1/4] iio: dac: mcp4725: use regulator framework
From: Lars-Peter Clausen <hidden>
Date: 2016-10-14 11:58:24
Also in:
linux-iio
On 10/11/2016 03:57 PM, Tomas Novotny wrote: Hi, Looks mostly good. One small thing that should be addressed.
quoted hunk
diff --git a/include/linux/iio/dac/mcp4725.h b/include/linux/iio/dac/mcp4725.h index 91530e6..7c062e8 100644 --- a/include/linux/iio/dac/mcp4725.h +++ b/include/linux/iio/dac/mcp4725.h@@ -10,7 +10,6 @@ #define IIO_DAC_MCP4725_H_ struct mcp4725_platform_data { - u16 vref_mv; };
Might as well remove the whole struct and file and drop the if (!pdata) check in the driver probe function. Having to declare a empty platform_data for the driver to work is not that sensible. -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html