Re: [PATCH 3/3] ARM: dts: lpc18xx: add boot rom node

Hi Vladimir,

On 7 October 2016 at 03:50, Vladimir Zapolskiy [off-list ref] wrote:

Hi Joachim,

On 13.09.2016 22:51, Joachim Eastwood wrote:

quoted

Add node for the boot ROM found on all NXP LPC18xx/43xx devices.

Signed-off-by: Joachim Eastwood <redacted>
---
 arch/arm/boot/dts/lpc18xx.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm/boot/dts/lpc18xx.dtsi b/arch/arm/boot/dts/lpc18xx.dtsi
index 631e6f6c..9f94f3e 100644
--- a/arch/arm/boot/dts/lpc18xx.dtsi
+++ b/arch/arm/boot/dts/lpc18xx.dtsi

@@ -81,6 +81,14 @@
                      status = "disabled";
              };

+             boot_rom: firmware@10400000 {
+                     compatible = "nxp,lpc1850-boot-rom";
+                     reg = <0x10400000 0x10000>;
+                     syscon = <&creg>;
+                     nvmem-cells = <&part_id>;

nitpicking, this change has a compile time dependency on yours
"nvmem: add lpc18xx OTP memory driver" series, I haven't noticed
this info stated, but it may be an overlook on my part.

It's not really a hard dependency and I will ensure that the DTS
changes comes in the correct order.

quoted

+                     nvmem-cell-names = "PartID";
+             };
+
              dmac: dma-controller@40002000 {
                      compatible = "arm,pl080", "arm,primecell";
                      arm,primecell-periphid = <0x00041080>;

Tested-by: Vladimir Zapolskiy <redacted>
Reviewed-by: Vladimir Zapolskiy <redacted>

Thanks for testing and going through the changes.


regards,
Joachim Eastwood
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html