Thread (1 message) 1 message, 1 author, 2016-10-03

Re: [PATCH v3 1/3] Documentation: dt: net: add mt76 wireless device binding

From: Kalle Valo <hidden>
Date: 2016-10-03 13:29:15
Also in: linux-wireless

Possibly related (same subject, not in this thread)

Arnd Bergmann [off-list ref] writes:
On Friday 30 September 2016, Felix Fietkau wrote:
quoted
quoted
quoted
quoted
quoted
quoted
quoted
+                 device_type = "pci";
+                 mediatek,mtd-eeprom = <&factory 0x8000>;
+                 mediatek,2ghz = <0>;
It's not clear what the possible values for the 2ghz property are,
can you be more verbose in the description? How is <0> different
from no property?
0 means disabled, no property means unchanged (compared to EEPROM).
Maybe have a boolean property instead then to say "mediatek,2ghz-disabled" ?

If zero is the only possible value, there is no need to put a number in there.
1 is also possible, which will force-enable the capability.
Ok, then both those values should be documented in the binding.
Related to this, Martin sent patches which add generic bindings for
enabling 2 Ghz and 5 Ghz bands.

[RFC,1/3] Documentation: dt-bindings: add IEEE 802.11 binding documentation
https://patchwork.kernel.org/patch/9359833/

[RFC,2/3] of: add IEEE 802.11 device configuration support code
https://patchwork.kernel.org/patch/9359837/

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help